Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week 8: Movies - Alexander & Malin #312

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Alexander-Gabor
Copy link

Copy link

@codeandjazz codeandjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi dear Alexander and Malin!

Your code is lovely to look at, and very readable. There is really not much to say other than, well done! ☺️🥳
If you could improve something, it would be to be more consequent when writing classnames for your elements. You can read more about that here:

➡️ https://www.freecodecamp.org/news/css-naming-conventions-that-will-save-you-hours-of-debugging-35cea737d849/amp/

I also added an example as a comment in the code so you can see what we mean by that.

When it comes to the website itself, it is just gorgeous. The spinning logo just adds a really great personal touch to it and gives it that professional look that we are all aspiring to reach. If I were a recruiter, I would be blown away instantly and would try to get you on my team asap!!

With all that said,

Stay smiling & keep up the good work hippos🦛
Tess & Daniel

Comment on lines +16 to +17
<div className="card-info">
<h1 className="movietitle"> {movie.title} </h1>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using both className="class-name" and className="classname" might cause some confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants